[TINKERPOP-2085]: Remove Mono dependency from gremlin-dotnet build/release#3548
Merged
Conversation
Contributor
|
VOTE +1 |
Contributor
Author
|
Merging as CTR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2085
Removes Mono from the gremlin-dotnet packaging/deploy pipeline, replacing mono nuget.exe pack/push with native dotnet pack/dotnet nuget push. Mono was only needed to run the Windows-only nuget.exe on Linux; the dotnet CLI has supported equivalent pack/push functionality since SDK 2.1+, so no functionality is
lost.
One behavioral change for release managers: the modern dotnet nuget push has no equivalent to the old nuget.exe setApiKey, which stored the key encrypted (via Windows DPAPI) in NuGet.Config — that encryption isn't available on Linux/macOS. Deploys now require an explicit -Dnuget.apiKey=[key] Maven property,
with a fail-fast check if it's omitted. (NuGet/Home#6437)
Changes:
I haven't yet tested this against a deployment to a live environment, my intention is to pull this forward to master, and try it out during the upcoming deployment of 4.0.0-beta.3. I will make any adjustments as necessary during that process.
VOTE +1