WICKET-7187 10.x: added type to JavaScript content header items#1511
Merged
bitstorm merged 1 commit intoJul 10, 2026
Conversation
If the type is not set on the header item, almost everything works as before. The only change to current behavior is that `equals(...)` and `hashCode(...)` of `JavaScriptContentHeaderItem` now also use the type. The type for JavaScript content header items are separate from the type for JavaScript reference header items because: * Reference header items only support a subset of the browser-processed types: `text/javascript` and `module`. * Using the same type for both types of header items would break backwards compatibility. * Some browser-processed types (import maps and speculation rules) deserve a dedicated API. Setting the type on `JavaScriptHeaderItem` would result in an unclear API when subtypes for these browser-processed types are added: these types know their type and will ignore the type set on their base class.
jstuyts
deleted the
feature/WICKET-7187-10.x-type-for-content-header-item
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the 10.x version of #1498.