Skip to content

fix: pass fallbackFile and VCS fields through push sites#345

Closed
ChiragAgg5k wants to merge 1 commit into
masterfrom
fix/push-sites-fallback-vcs-fields
Closed

fix: pass fallbackFile and VCS fields through push sites#345
ChiragAgg5k wants to merge 1 commit into
masterfrom
fix/push-sites-fallback-vcs-fields

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

What does this PR do?

appwrite push sites omitted fallbackFile and git/VCS fields (installationId, providerRepositoryId, providerBranch, providerSilentMode, providerRootDirectory) from both create and update payloads, so values declared in appwrite.config.json were ignored.

This PR:

  • Passes those fields through on sitesService.create / update in pushSites
  • Adds the VCS fields to the site config schema (strict) so they are valid in appwrite.config.json
  • Includes them when pulling sites so config round-trips

Test Plan

  1. Set fallbackFile: "index.html" on a site in appwrite.config.json.
  2. Run appwrite push sites --site-id <id> --force.
  3. Run appwrite sites get --site-id <id> and confirm fallbackFile is set.
  4. Optionally set installationId / providerRepositoryId / providerBranch / providerRootDirectory / providerSilentMode and confirm they are applied on push.
  5. appwrite pull sites should write those fields back into the config.

Related PRs and Issues

Checklist

  • Have you read the contributing guidelines?

push sites ignored SPA fallbackFile and git connection fields from appwrite.config.json even though sites create/update already accept them. Pass them through on create/update and allow them in the site config schema.

Co-authored-by: Cursor <cursoragent@cursor.com>
@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown

Greptile Summary

The PR completes site configuration round-tripping by:

  • accepting fallback and VCS fields in the strict site schema
  • copying VCS values from remote sites during pull
  • forwarding fallback and VCS values through site create and update requests

Confidence Score: 5/5

The PR appears safe to merge, with the added site fields consistently represented across schema, pull, and push paths.

The changes align the strict site configuration shape with the explicit pull mapping and both outbound site mutation paths, and no concrete blocking or non-blocking defect remains.

Important Files Changed

Filename Overview
lib/commands/config.ts Adds the five VCS properties to SiteSchema so validation and schema-derived persistence whitelists retain them.
lib/commands/pull.ts Maps the remote site's VCS properties into the local site configuration for round-trip persistence.
lib/commands/push.ts Passes fallbackFile and all five VCS properties through both site creation and update payloads.

Reviews (1): Last reviewed commit: "fix: pass fallbackFile and VCS fields th..." | Re-trigger Greptile

@ChiragAgg5k

Copy link
Copy Markdown
Member Author

Closing — SDK changes must land in sdk-generator (generated SDKs), not as a direct edit to sdk-for-cli.

@ChiragAgg5k
ChiragAgg5k deleted the fix/push-sites-fallback-vcs-fields branch July 24, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

push sites doesn't apply fallbackFile or the git/VCS fields from appwrite.config.json

1 participant