fix: pass fallbackFile and VCS fields through push sites#345
Closed
ChiragAgg5k wants to merge 1 commit into
Closed
fix: pass fallbackFile and VCS fields through push sites#345ChiragAgg5k wants to merge 1 commit into
ChiragAgg5k wants to merge 1 commit into
Conversation
push sites ignored SPA fallbackFile and git connection fields from appwrite.config.json even though sites create/update already accept them. Pass them through on create/update and allow them in the site config schema. Co-authored-by: Cursor <cursoragent@cursor.com>
Greptile SummaryThe PR completes site configuration round-tripping by:
Confidence Score: 5/5The PR appears safe to merge, with the added site fields consistently represented across schema, pull, and push paths. The changes align the strict site configuration shape with the explicit pull mapping and both outbound site mutation paths, and no concrete blocking or non-blocking defect remains. Important Files Changed
Reviews (1): Last reviewed commit: "fix: pass fallbackFile and VCS fields th..." | Re-trigger Greptile |
Member
Author
|
Closing — SDK changes must land in sdk-generator (generated SDKs), not as a direct edit to sdk-for-cli. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
appwrite push sitesomittedfallbackFileand git/VCS fields (installationId,providerRepositoryId,providerBranch,providerSilentMode,providerRootDirectory) from both create and update payloads, so values declared inappwrite.config.jsonwere ignored.This PR:
sitesService.create/updateinpushSitesappwrite.config.jsonTest Plan
fallbackFile: "index.html"on a site inappwrite.config.json.appwrite push sites --site-id <id> --force.appwrite sites get --site-id <id>and confirmfallbackFileis set.installationId/providerRepositoryId/providerBranch/providerRootDirectory/providerSilentModeand confirm they are applied on push.appwrite pull sitesshould write those fields back into the config.Related PRs and Issues
Checklist