chore: ix addr-of toString fallback for non-round-tripping names#448
Closed
samuelburnham wants to merge 1 commit into
Closed
chore: ix addr-of toString fallback for non-round-tripping names#448samuelburnham wants to merge 1 commit into
ix addr-of toString fallback for non-round-tripping names#448samuelburnham wants to merge 1 commit into
Conversation
addr-of --ixe resolved a name only via parseName + structural lookup, so names whose components don't round-trip through naive dot-splitting (macro-scoped/hygienic names, all-digit string components) failed even when present. ix check already handles this via resolveIxeAddr's toString fallback; addr-of now resolves the same set of names. Rather than duplicate the helpers, factor parseName, resolveName, ixNameToLeanName, and resolveIxeAddr out of CheckCmd into a new lightweight Ix.Cli.NameResolve module. It depends only on Address/Environment/Ixon, so addr-of (and future benchmark drivers) can resolve names without pulling in the Aiur typecheck machinery that CheckCmd carries. Both commands now share one definition.
samuelburnham
force-pushed
the
sb/addr-of-fallback
branch
from
f2f068f to
2371263
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addr-of --ixeresolved a name only via parseName + structural lookup, so names whose components don't round-trip through naive dot-splitting (macro-scoped/hygienic names, all-digit string components) failed even when present. ix check already handles this via resolveIxeAddr's toString fallback; addr-of now resolves the same set of names.Rather than duplicate the helpers, factor parseName, resolveName, ixNameToLeanName, and resolveIxeAddr out of CheckCmd into a new lightweight Ix.Cli.NameResolve module. It depends only on Address/Environment/Ixon, so addr-of (and future benchmark drivers) can resolve names without pulling in the Aiur typecheck machinery that CheckCmd carries. Both commands now share one definition.
Intended to be used by #427 or a follow-up PR