chore: update otel readme, plugin constructor#490
Open
wangyb-A wants to merge 1 commit into
Open
Conversation
SilanHe
reviewed
Jun 24, 2026
Comment on lines
+180
to
+181
| # Ratio used by TraceIdRatioBased sampling (default: 1.0). | ||
| sampling_rate=1.0, |
Contributor
There was a problem hiding this comment.
Since the ADOT layer already has this configuration, do we really need this configuration in the plugin?
| The layer ARN follows the format: | ||
|
|
||
| ``` | ||
| arn:aws:lambda:<region>:901920570463:layer:aws-otel-python-<arch>-ver-<version> |
Contributor
There was a problem hiding this comment.
nit: I also made put the awsAccountId between <> since the accountId changes between regions for the layer.
Contributor
There was a problem hiding this comment.
nit: repeats below in all references of the layer.
|
|
||
| - `otel_trace_id`: 32-char hex trace identifier | ||
| - `otel_span_id`: 16-char hex span identifier | ||
| - `otel_trace_sampled`: boolean indicating if the trace is sampled |
Contributor
There was a problem hiding this comment.
if the customer specifies th sampling ratio on the layer's env variable, will this be accurate?
|
|
||
|
|
||
| @durable_execution(plugins=[otel]) | ||
| @durable_execution(plugins=[DurableExecutionOtelPlugin()]) |
Contributor
There was a problem hiding this comment.
nit: we've renamed the plugin in other SDKs to OtelPlugin. You an follow up in another PR if you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
providerparameter as optionalBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.