Skip to content

use class-based temporaryBucketName for s3 stability test buckets#7099

Merged
joviegas merged 1 commit into
masterfrom
joviegas/test-names
Jul 2, 2026
Merged

use class-based temporaryBucketName for s3 stability test buckets#7099
joviegas merged 1 commit into
masterfrom
joviegas/test-names

Conversation

@joviegas

@joviegas joviegas commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

The S3 CRT stability tests hardcode their bucket names via String.format(...)
instead of using the shared S3BucketUtils.temporaryBucketName(...) helper. As a
result their bucket prefixes don't correspond to the test class name (also there is
a typo: s3crtasyncclinet... for S3CrtAsyncClientStabilityTest).

Modifications

Switched the bucket names in the S3 stability tests from hardcoded strings to
temporaryBucketName(<TestClass>.class), so each bucket prefix is derived from its
test class name (consistent with the other S3 integration tests):

  • S3CrtAsyncClientStabilityTest (also fixes the clinet typo)
  • S3CrtClientStabilityTest
  • S3MultipartJavaBasedStabilityTest
  • S3NettyAsyncStabilityTest
  • S3AsyncWithCrtAsyncHttpClientStabilityTest

S3MockWithAsyncClientStabilityTest is left unchanged — it uses a mock HTTP client
and never creates a real bucket.

The module already depends on service-test-utils, so no new dependency was needed.

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner July 2, 2026 20:46
@joviegas joviegas added this pull request to the merge queue Jul 2, 2026
Merged via the queue into master with commit 13086d7 Jul 2, 2026
13 checks passed
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants