use class-based temporaryBucketName for s3 stability test buckets#7099
Merged
Conversation
Fred1155
approved these changes
Jul 2, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The S3 CRT stability tests hardcode their bucket names via
String.format(...)instead of using the shared
S3BucketUtils.temporaryBucketName(...)helper. As aresult their bucket prefixes don't correspond to the test class name (also there is
a typo:
s3crtasyncclinet...forS3CrtAsyncClientStabilityTest).Modifications
Switched the bucket names in the S3 stability tests from hardcoded strings to
temporaryBucketName(<TestClass>.class), so each bucket prefix is derived from itstest class name (consistent with the other S3 integration tests):
S3CrtAsyncClientStabilityTest(also fixes theclinettypo)S3CrtClientStabilityTestS3MultipartJavaBasedStabilityTestS3NettyAsyncStabilityTestS3AsyncWithCrtAsyncHttpClientStabilityTestS3MockWithAsyncClientStabilityTestis left unchanged — it uses a mock HTTP clientand never creates a real bucket.
The module already depends on
service-test-utils, so no new dependency was needed.License