Skip to content

refactor: nest NODE_VERSIONS, version -> repositories#3917

Merged
jbedard merged 1 commit into
bazel-contrib:mainfrom
gzm0:structure-node-versions
Jun 16, 2026
Merged

refactor: nest NODE_VERSIONS, version -> repositories#3917
jbedard merged 1 commit into
bazel-contrib:mainfrom
gzm0:structure-node-versions

Conversation

@gzm0

@gzm0 gzm0 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This is in preparation for facts (#3916) which will need this structure.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The (generated) NODE_VERSIONS value mirrors the structure of the node_repositories attribute.
As a result, extracting which node versions are built-in requires string mangling.

What is the new behavior?

The NODE_VERSIONS value is keyed by node versions. The values are the "node repositories".

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is in preparation for facts which will need this structure.
@jbedard jbedard merged commit e6706c5 into bazel-contrib:main Jun 16, 2026
27 checks passed
@gzm0 gzm0 deleted the structure-node-versions branch June 17, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants