feat: auto-fetch node versions in module extension#3919
Open
gzm0 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26e0a05fdf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
More aggressive alternative to bazel-contrib#3916: We even do the fetching if facts are not available.
12 tasks
jbedard
reviewed
Jun 18, 2026
jbedard
approved these changes
Jun 19, 2026
Collaborator
|
I think this LGTM, are you in favour of merging this one over #3916? |
Contributor
Author
|
Yes, I'm in favor of this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More aggressive alternative to #3916: We even do the fetching if facts are not available.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Node versions / digests are hardcoded and shipped with rules_nodejs.
What is the new behavior?
rules_nodejs retrieves required Node digests as needed and stores them in facts or in generatedRepoSpecs in the bzlmod lockfile.
Does this PR introduce a breaking change?
Other information