rustc: add support for split debuginfo#4092
Open
slackito wants to merge 6 commits into
Open
Conversation
slackito
force-pushed
the
split-debug-info
branch
2 times, most recently
from
5dd4ee1 to
b9fc501
Compare
This requires some helper logic in the process wrapper so we can move dwo files to predictable output locations, but otherwise it's mostly straightforward. This requires a bazel built after d2c79821cd45b30eeaec2efc3bd5fbd26f37d3c2, but that's old enough it landed in bazel 8.
…uration` is present.
The `rust_flags` argument in `construct_arguments` now supports (format_string, File) tuples as elements in addition to strings, when using the list format. This allows bazel to apply path mapping on the dwarf output directory flag. Also added analysis tests for `--fission=yes` and `--fission=no`. The test cases were written by Gemini and reviewed by me. Assisted-by: Gemini
Fission support requires passing `-Zsplit-dwarf-out-dir` which is not available in stable rustc.
slackito
force-pushed
the
split-debug-info
branch
from
76726d5 to
a0b39d0
Compare
Collaborator
Author
|
Rebased on top of current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #3168 by @durin42, with fixes for some of the pre-merge checks.
This PR adapts the original change to support path mapping when passing
-Zsplit-dwarf-out-dir=<path>. In order to do this, it adds toconstruct_argumentsthe option to pass(format_string, File)as elements in the list form ofrustc_flags. This PR also adds tests for the new functionality.The new changes on top of the original PR were written with assistance by Gemini.