fix: TRAC-896 - avoid archiveManager readEntry stall on Windows/Node 24 CI#1390
Merged
jairo-bc merged 1 commit intoJul 7, 2026
Conversation
jairo-bc
changed the title
jairo-bc
force-pushed
the
jairopanduro/ltrac-928-stencil-cli-archivemanager-extractzipfiles-tests-time-out-on
branch
from
4040f7b to
b51ad0f
Compare
rtalvarez
approved these changes
Jul 7, 2026
…24 CI extractZipFiles() called zipFile.readEntry() for the next entry immediately after the previous entry's pipeline() resolved. On windows-latest with Node 24.x this stalls once a second real read+inflate cycle is requested, timing out CI (build (24.x, windows-latest) failing on PR #1383). The three fastest-failing tests only skip to the next entry after a completed extraction cycle; tests that resolve/reject on the first entry are unaffected. Yield a tick (setImmediate) before calling readEntry() so the prior entry's zlib inflate stream and fd fully tear down before the next entry is requested. Fixes TRAC-896
jairo-bc
force-pushed
the
jairopanduro/ltrac-928-stencil-cli-archivemanager-extractzipfiles-tests-time-out-on
branch
from
b51ad0f to
3c3f2d4
Compare
Contributor
|
🎉 This PR is included in version 9.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
extractZipFiles()calledreadEntry()right afterpipeline()resolvedwindows-latest+ Node 24.x once a 2nd real read+inflate cycle is requested (exceeds Jest's 5000ms timeout)setImmediate) beforereadEntry()so previous entry's zlib/fd fully tear downbuild (24.x, windows-latest)passed twice after this fixTickets / Documentation
cc @bigcommerce/storefront-team