feat(utxo-locking)!: Add commands to lock, unlock and list locked UTXOs#294
Open
tvpeter wants to merge 12 commits into
Open
feat(utxo-locking)!: Add commands to lock, unlock and list locked UTXOs#294tvpeter wants to merge 12 commits into
tvpeter wants to merge 12 commits into
Conversation
- add BdkCli helper struct and impl methods - add integration tests for the key subcommand operations
- Add integration tests for wallets, descriptor, compile and config modules
- add integration tests for offline wallet operations
- Add test for creating, signing, broadcasting tx - Add test for combining psbt, fee bump and other psbt related commands - Add bip322 tests
- add saving proxy_opts for electrum and esplora clients to config and reading values - fix prepare_home_dir util fn
- Update bdk_wallet to v3.1.0 - Replaced Network enum with NetworkKind - Replaced `include_output_redeem_witness_script` with `add_global_xpubs` - update bdk_redb to v0.2.0
- update bdk_kyoto to v0.17.0 - add ew broadcast/subscriber API for KyotoClient
- add wallet commands to lock, unlock and list locked utxos - update unspent command to show status of each outpoint
tvpeter
changed the title
-Temporary disable bip322 feature
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
==========================================
+ Coverage 56.89% 57.02% +0.12%
==========================================
Files 22 22
Lines 3661 3644 -17
==========================================
- Hits 2083 2078 -5
+ Misses 1578 1566 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
-add test for locking, unlocking and listing locked utxos
tvpeter
force-pushed
the
feat/utxo-locking
branch
from
e26cf5e to
aba6c66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Wallet API to v3.1.0 and adds wallet subcommands to lock and unlock UTXOs. Locked outpoints are excluded from coin selection, and the lock state is stored in the wallet. It also updates the
bdk_redbto v0.2.0 andbdk_kyototo v0.17.0.Fixes #293 and builds upon #289 and #278
Notes to the reviewers
Changelog notice
lock_utxocommandunlock_utxocommandlocked_uxtoscommandNetworkenum withNetworkKindinclude_output_redeem_witness_scriptwithadd_global_xpubsin TxBuildersubmit_packagewithbroadcast_randomfor broadcasting transactions in KyotoClientChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md