Skip to content

Update shlex to 2.0.1#2244

Merged
jeckersb merged 1 commit into
bootc-dev:mainfrom
jeckersb:shlex-2.0.1
Jun 12, 2026
Merged

Update shlex to 2.0.1#2244
jeckersb merged 1 commit into
bootc-dev:mainfrom
jeckersb:shlex-2.0.1

Conversation

@jeckersb

Copy link
Copy Markdown
Collaborator

The 2.0.0 release had a bug which broke the docs build, which in turn
causes cargo doc to fail for bootc as well.

We explicitly use --no-deps in our validate job when building our
docs so we don't catch things like this in other crates, but it's
annoying when I want to generate all the docs locally.

Signed-off-by: John Eckersberg jeckersb@redhat.com

The 2.0.0 release had a bug which broke the docs build, which in turn
causes `cargo doc` to fail for bootc as well.

We explicitly use `--no-deps` in our validate job when building our
docs so we don't catch things like this in other crates, but it's
annoying when I want to generate all the docs locally.

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
@bootc-bot bootc-bot Bot requested a review from henrywang June 10, 2026 19:02
@jeckersb

Copy link
Copy Markdown
Collaborator Author

Actually nevermind this is already included in #2226 I didn't realize that one is still stuck trying to get through the merge queue 😭

@jeckersb jeckersb closed this Jun 10, 2026
@jeckersb

Copy link
Copy Markdown
Collaborator Author

Ok nevermind, despite #2226 listing

[shlex](https://crates.io/crates/shlex) workspace.dependencies patch 2.0.0 → 2.0.1

in the description, it didn't actually update shlex...

@jeckersb jeckersb reopened this Jun 11, 2026
@cgwalters cgwalters enabled auto-merge June 11, 2026 13:22
@cgwalters cgwalters added this pull request to the merge queue Jun 11, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 11, 2026
@jeckersb jeckersb added this pull request to the merge queue Jun 11, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 11, 2026
@jeckersb jeckersb added this pull request to the merge queue Jun 12, 2026
@jeckersb jeckersb removed this pull request from the merge queue due to a manual request Jun 12, 2026
@jeckersb jeckersb added this pull request to the merge queue Jun 12, 2026
Merged via the queue into bootc-dev:main with commit 85ad2f9 Jun 12, 2026
29 checks passed
@jeckersb jeckersb deleted the shlex-2.0.1 branch June 12, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants