Updating databases and fixing a browser major version matching error#17
Open
danielpietzsch wants to merge 5 commits into
Open
Updating databases and fixing a browser major version matching error#17danielpietzsch wants to merge 5 commits into
danielpietzsch wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @bramus,
I'm not sure, if you would still publish updates to this package. But I wanted to use an updated version myself, so I updated the DBs and also fixed a problem with version matching:
I noticed some results were not accurate when comparing to the web version. My favourite coding agent quickly found it's apparently a version-number matching issue. The fixes seem to have worked, but I have only tested this with a very small number of feature-queries (for example for
allow-discrete, where this was previously diverting from the display on caniuse.com).Also: the major version bumps for
@mdn/browser-compat-dataseem fine, as the breaking changes do not seem to have affected this repo. But here also, I have not super thoroughly tested everything beyond "doing a lot of queries, and they all seem to work" and "my LLM says it's fine".