Skip to content

fix(sfcompute-v2): update sfc-go, adopt capacities -> pools rename#125

Merged
drewmalin merged 3 commits into
brevdev:mainfrom
sfcompute:seb/sfcompute-v2-pools-rename
Jun 29, 2026
Merged

fix(sfcompute-v2): update sfc-go, adopt capacities -> pools rename#125
drewmalin merged 3 commits into
brevdev:mainfrom
sfcompute:seb/sfcompute-v2-pools-rename

Conversation

@Sladuca

@Sladuca Sladuca commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

This PR makes two updates to the sfcompute-v2 provider, which is built against our preview v2 API:

  1. We made some breaking schema changes to fields that brev doesn't use, but sfc-go would fail deserializing. We separately pushed an update to sfc-go - this PR updates to the new version.
  2. We renamed Capacities to Pools. While this is not breaking (we still support the old name), we can take the opportunity here to adopt the new naming.

Sladuca and others added 3 commits June 26, 2026 12:33
sfc-go renamed the Capacities resource to Pools (capResp.PoolResponse,
client.Pools.Fetch) and the instance create/list filter field from
capacity to pool (ListInstancesRequest.Pool is now a repeatable []string).
Update the V2 integration to the new SDK shape.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The pool rename also changed the resource-path prefix from sfc:capacity:
to sfc:pool:. Update GetDefaultPoolResourcePath (renamed from
GetDefaultCapacityResourcePath) so the path the API receives is valid.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Sladuca Sladuca requested a review from a team as a code owner June 29, 2026 18:09
@drewmalin drewmalin merged commit 523b4eb into brevdev:main Jun 29, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants