fix: keep the hero glyph in the background#320
Merged
Conversation
.VPHome had no stacking context, so the z-index:0 ::after glyph painted over the hero content. Isolate .VPHome and drop the glyph to z-index:-1.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the VitePress home hero background motif layering so the .VPHome::after glyph renders behind the hero content rather than on top of it.
Changes:
- Add
isolation: isolateto.VPHometo create an isolated stacking context. - Move the
.VPHome::afterpseudo-element behind hero content by changing itsz-indexfrom0to-1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.VPHome::aftermotif glyph was painting over the hero content:.VPHomeusedposition: relativewith noz-index, so it formed no stacking context, and thez-index: 0absolute pseudo-element rendered above the in-flow hero heading/logo/mascot. Fix isolates.VPHome(isolation: isolate) and drops the glyph toz-index: -1, so it sits behind the content as intended. Same fix applied across all five docs sites.