Fix webhook create/list output to use protojson#4592
Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
The repo lint rule forbids direct protojson.MarshalOptions use; private/pkg/protoencoding is the sanctioned wrapper.
doriable
approved these changes
Jun 22, 2026
doriable
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thank you for putting this up! We also chatted about testing out this fix etc.
Stamping ahead of time, but do you mind adding a changelog statement for this, since this fixes a user-facing issue with webhooks? Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
buf beta registry webhook createandbuf beta registry webhook listprinting empty objects ({}/[{}]) instead of actual webhook data.Root cause: both commands used
encoding/jsonto marshal proto-generated structs. Proto structs store field data in unexported fields, invisible toencoding/json, so all fields silently serialize as zero values. Fix is to replaceencoding/json.MarshalIndentwithprotojson.MarshalOptions{Multiline: true, Indent: "\t"}.Marshal, which uses the protobuf reflection API and correctly reads proto field values.Note: the
createoutput shape changes from a bare{...}to{"webhook": {...}}to match the RPC response structure.