Bug 2052749: Example extension causes the t/markdown test to fail#166
Merged
Conversation
mrenvoize
approved these changes
Jul 6, 2026
mrenvoize
left a comment
mrenvoize
left a comment
Contributor
There was a problem hiding this comment.
Another clear improvement, approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
The test itself is probably too loose - it's passing a test string that would commonly be used elsewhere for something else (like in the Example extension, which also uses 'foo' in a replacement that trips the test). The most robust fix for this is to make the test pass a tag that won't likely ever get used in a production use case.
Additional info
Test Plan
rm extensions/Example/disabledsh docker/run-tests-in-docker.sh- pick option 6rm extensions/Example/disabledsh docker/run-tests-in-docker.sh- pick option 6