Skip to content

Make wac plug output deterministic #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
techieyann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make wac plug output deterministic #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/commands/plug.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,12 @@ impl PlugCommand {
let socket = Package::from_bytes("socket", None, socket, graph.types_mut())?;
let socket = graph.register_package(socket)?;

// Collect the plugs by their names
let mut plugs_by_name = std::collections::HashMap::<_, Vec<_>>::new();
// Collect the plugs by their names.
// An insertion-ordered map is used so that plugs are registered and
// instantiated in command-line order, which makes the encoded output
// deterministic; iterating a `HashMap` here made the emitted component
// order vary between runs on identical inputs.
let mut plugs_by_name = indexmap::IndexMap::<_, Vec<_>>::new();
for plug in self.plugs.iter() {
let name = match plug {
#[cfg(feature = "registry")]
Expand Down
Loading