Skip to content

Fix treeify soundness: never treeify (sink) effectful ops at all. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfallin merged 1 commit into from
Jul 24, 2026
Merged

Fix treeify soundness: never treeify (sink) effectful ops at all. #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/backend/treeify.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ impl Trees {
let mut multi_use = HashSet::default();

for block_def in body.blocks.values() {
let mut last_non_pure = None;
for &value in &block_def.insts {
match &body.values[value] {
&ValueDef::Operator(op, args, _) => {
Expand Down Expand Up @@ -71,17 +70,13 @@ impl Trees {
} else if let Some(old_owner) = owner.remove(&arg) {
owned.remove(&old_owner);
multi_use.insert(arg);
} else if Self::is_movable(body, arg) || Some(arg) == last_non_pure {
} else if Self::is_movable(body, arg) {
let pos = u16::try_from(i).unwrap();
let value_arg = ValueArg(value, pos);
owner.insert(arg, value_arg);
owned.insert(value_arg, arg);
}
}

if !op.is_pure() {
last_non_pure = Some(value);
}
}
&ValueDef::PickOutput(..) => {
// Can ignore use: multi-arity values are never treeified.
Expand Down
Loading