Skip to content

chore: upgrade major version for cap and spring-boot#113

Open
Schmarvinius wants to merge 5 commits into
mainfrom
chore/upgrade-java-25-cds-services-5-spring-boot-4
Open

chore: upgrade major version for cap and spring-boot#113
Schmarvinius wants to merge 5 commits into
mainfrom
chore/upgrade-java-25-cds-services-5-spring-boot-4

Conversation

@Schmarvinius

Copy link
Copy Markdown
Contributor
  • Adapted java min version to 21 according to cap java 5.0.0
  • Bumped Major Versions for cds-services and spring-boot in plugins and also for sample
  • Bumped Revision to 0.0.2-alpha

@Schmarvinius Schmarvinius requested a review from a team as a code owner July 6, 2026 12:25
@hyperspace-insights

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Upgrade Major Versions for CAP Java and Spring Boot

Chore

🔧 Bumped major dependency versions across the project, adapting the minimum Java version and updating import paths broken by the Spring Boot 4.x package reorganization.

Changes

  • pom.xml: Updated revision to 0.0.2-alpha, raised java.version from 1721, bumped cds.services.version from 4.9.05.0.0, and upgraded spring.boot.version from 3.4.54.1.0.
  • samples/bookshop/pom.xml: Aligned the bookshop sample with the same major version bumps (java.version 17 → 21, cds.services.version 4.9.0 → 5.0.0, spring.boot.version 3.5.6 → 4.1.0).
  • integration-tests/mtx-local/srv/pom.xml & integration-tests/spring/pom.xml & samples/bookshop/srv/pom.xml: Added spring-boot-starter-webmvc-test as a test-scoped dependency, required by Spring Boot 4.x.
  • MtxLifecycleTest.java, SubscribeUnsubscribeTest.java, TenantIsolationTest.java, BaseIntegrationTest.java, ApplicationTest.java: Migrated @AutoConfigureMockMvc import from the deprecated org.springframework.boot.test.autoconfigure.web.servlet package to the new org.springframework.boot.webmvc.test.autoconfigure package introduced in Spring Boot 4.x.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.26.14

  • Summary Prompt: Default Prompt
  • Event Trigger: pull_request.opened
  • LLM: anthropic--claude-4.6-sonnet
  • Output Template: Default Template
  • File Content Strategy: Full file content
  • Correlation ID: bd55cb20-7935-11f1-8029-de772f42838d

@hyperspace-insights hyperspace-insights Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR upgrades CDS/Spring Boot to major versions but has two concrete bugs: the spring-boot-starter-webmvc-test artifact ID is incorrect across all three POMs (should be spring-boot-webmvc-test), and the samples/bookshop sample still references the old 0.0.1-alpha version of cds-starter-ai after the project was bumped to 0.0.2-alpha. Both issues will cause build or resolution failures and must be fixed before merging.

PR Bot Information

Version: 1.26.14

  • Correlation ID: bd55cb20-7935-11f1-8029-de772f42838d
  • LLM: anthropic--claude-4.6-sonnet
  • Event Trigger: pull_request.opened
  • File Content Strategy: Full file content


<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-webmvc-test</artifactId>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: spring-boot-starter-webmvc-test is not a valid Spring Boot artifact — the correct artifact for the WebMVC test autoconfigure module in Spring Boot 4.x is spring-boot-webmvc-test (no "starter" prefix). Using the wrong artifact ID will cause a dependency resolution failure.

Suggested change
<artifactId>spring-boot-starter-webmvc-test</artifactId>
<artifactId>spring-boot-webmvc-test</artifactId>

Double-check suggestion before committing. Edit this comment for amendments.


Please provide feedback on the review comment by checking the appropriate box:

  • 🌟 Awesome comment, a human might have missed that.
  • ✅ Helpful comment
  • 🤷 Neutral
  • ❌ This comment is not helpful

Comment thread integration-tests/spring/pom.xml
Comment thread samples/bookshop/srv/pom.xml
Comment thread samples/bookshop/pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant