feat: integrate utils/cert, remove local replace#45
Open
M09Ic wants to merge 1 commit into
Open
Conversation
Use published utils/cert and utils/mitmproxy instead of local replace directives. utils/cert provides atomic certificate generation primitives (NewTemplate, SelfSign/SignWith, Fingerprint, TLS config builder, etc.) that mitmproxy now uses for CA creation and DummyCert key-reuse. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils/certandutils/mitmproxyinstead of localreplacedirectivesutils/certprovides atomic certificate primitives (NewTemplate, SelfSign/SignWith, TLS config builder, Fingerprint, etc.)NewTemplate+SignWithatoms for key-reuse patternTestMITMCapture_ServerFirst_Fallback(server-probe byte consumption)Changes
go.mod: remove../utils/certand../utils/mitmproxylocal replace, use publishedv0.0.0-20260624182357-8d5cad72d8f2mitm_bench_test.go: tolerate partial SSH banner in server-first testTest plan
go test ./pkg/tools/proxy/...— 33/33 passgo build ./...— compiles cleango vet ./...— no warnings🤖 Generated with Claude Code