feat: accept messages from key contacts with forged From address#8382
Open
link2xt wants to merge 1 commit into
Open
feat: accept messages from key contacts with forged From address#8382link2xt wants to merge 1 commit into
link2xt wants to merge 1 commit into
Conversation
From address is not used for key contacts other than as the address to send replies to.
link2xt
force-pushed
the
link2xt/lnxsrknwkmnq
branch
from
5690577 to
0e6d8c4
Compare
Collaborator
Author
|
This likely affects https://github.com/deltachat-bot/deltachat-loginbot as the bot authenticates email address, and now email address during securejoin can come entirely from the protected header that is not checked by the server, so sending |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From address is not used for key contacts
other than as the address to send replies to.