Skip to content

Add multiple editor tabs #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
makermelissa merged 1 commit into from
Jul 24, 2026
Merged

Add multiple editor tabs #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
<button class="purple-button btn-format">Format<i class="fa-solid fa-wand-magic-sparkles"></i></button>
<button class="purple-button btn-save">Save<i class="fa-solid fa-floppy-disk"></i></button>
<button class="purple-button btn-save-as">Save As<i class="fa-solid fa-download"></i></button>
<div class="file-path"></div>
<button class="purple-button btn-save-run">Save + Run<i class="fa-solid fa-play"></i></button>
</div>
<div id="mobile-editor-bar">
Expand All @@ -82,7 +81,6 @@
</button>
</div>
</div>
<div class="file-path"></div>
<a class="purple-button btn-save-run">Save + Run<i class="fa-solid fa-play"></i></a>
<div class="clear"></div>
<nav id="mobile-menu-contents" role="navigation" class="hidden" aria-expanded="false" aria-label="Mobile Menu">
Expand All @@ -95,6 +93,10 @@
</ul>
</nav>
</div>
<div id="editor-tabs-wrapper">
<div id="editor-tabs" role="tablist" aria-label="Open files"></div>
<select id="editor-tab-select" aria-label="Switch open file" hidden></select>
</div>
<div id="editor" tabindex="0"></div>
</div>
<div id="page-separator" class=""></div>
Expand Down
29 changes: 17 additions & 12 deletions js/layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,21 @@ export function showSerial() {
updatePageLayout(UPDATE_TYPE_SERIAL);
}

function updateModeButtons() {
// Match the button state to the panel state to avoid getting out of sync
if (isEditorVisible()) {
btnModeEditor.classList.add('active');
} else {
btnModeEditor.classList.remove('active');
}

if (isSerialVisible()) {
btnModeSerial.classList.add('active');
} else {
btnModeSerial.classList.remove('active');
}
}

// update type is used to indicate which button was clicked
function updatePageLayout(updateType) {
// If both are visible, show the separator
Expand All @@ -110,6 +125,7 @@ function updatePageLayout(updateType) {
editorPage.style.flex = null;
serialPage.style.width = null;
serialPage.style.flex = null;
updateModeButtons();
return;
}

Expand All @@ -133,18 +149,7 @@ function updatePageLayout(updateType) {
serialPage.style.flex = 'none';
}

// Match the button state to the panel state to avoid getting out of sync
if (isEditorVisible()) {
btnModeEditor.classList.add('active');
} else {
btnModeEditor.classList.remove('active');
}

if (isSerialVisible()) {
btnModeSerial.classList.add('active');
} else {
btnModeSerial.classList.remove('active');
}
updateModeButtons();

if (isSerialVisible()) {
refitTerminal();
Expand Down
Loading