Skip to content

Fallback for serial USB drive helpers - #540

Closed
makermelissa-ai-assistant wants to merge 1 commit into
circuitpython:betafrom
makermelissa-ai-assistant:issue-serial-usb-drive-helper-fallback
Closed

Fallback for serial USB drive helpers#540
makermelissa-ai-assistant wants to merge 1 commit into
circuitpython:betafrom
makermelissa-ai-assistant:issue-serial-usb-drive-helper-fallback

Conversation

@makermelissa-ai-assistant

Copy link
Copy Markdown
Contributor

Summary

  • fall back to inline CircuitPython snippets when circuitpython-repl-js does not expose tryDisableUsbDrive() / enableUsbDrive()
  • preserves serial file transfer for supported beta firmware such as 10.3.0-alpha builds even when the bundled REPL helper API is unavailable

Testing

  • npm run build
  • git diff --check

Notes

Console error observed before this fix:

Unable to disable the CIRCUITPY USB drive: TypeError: this.repl.tryDisableUsbDrive is not a function

@makermelissa

Copy link
Copy Markdown
Collaborator

We're not going this route because it circumvents the advantage of putting the code in circuitpython-repl-js. It would require any code changes in 2 places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants