Introduce new manual tests format#1411
Merged
Merged
Conversation
…`manualStaticAssetsPlugin()` Vite plugin.
…ntries with the `<ck-manual-header>` component replacing the shell-based page composition, a new `rawSvgPlugin()`, removal of `rawHtmlPlugin()`, and Vite 8.1 support in `refreshPlugin()`.
…sed `packageRootPath` field and the `vite-svg-loader` dependency.
…ndencies. It existed only for the one-off migration of manual test instruction files.
… to `tests/manual/` instead of extracting `<title>`, and accept package root globs in the `paths` option.
…y and the test-only `getManualStaticAssetFilePath()` export, share the `include` package filter between plugins, and use the filtered `load` hook in the SVG plugin.
…uarantees every match contains the `tests/manual` segment.
…ev. Vite never regenerates HTML entries in the in-memory bundle, so the plugin splices the freshly built `<head>` with the post-`</head>` markup read from disk.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…r bundledDev. The bundled dev HTML source freshness splice only refreshes the post-</head> markup, so adding or removing <ck-manual-header> updates the body but leaves the injected header chrome (<meta> and component script) in <head> stale until a restart. Clarify the comment to cover this case alongside head-confined edits.
The wrap functions now report whether they patched their internal, so the startup assertion builds its missing-internals list from those results instead of duplicating the same checks. The `devEngine` presence check is reduced to an `in` test, since the getter always throws before the initial build and the previous branches were unreachable at startup.
filipsobol
changed the title
filipsobol
changed the title
…t is not served a stale bundle.
… the workspace root itself.
…kage, matching the manual page resolution.
przemyslaw-zan
requested changes
Jul 7, 2026
przemyslaw-zan
left a comment
przemyslaw-zan
left a comment
Member
There was a problem hiding this comment.
Works well, I only have a few nitpicks.
The workarounds could use a reference to rolldown/rolldown#10022 (comment).
…t leading slashes, find the head closing tag without lowercasing, and drop the stale .md extension from processed manual test assets.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6958f53. Configure here.
…en when a head comment or script contains a </head> literal.
przemyslaw-zan
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Introduce new manual tests format.
📌 Related issues
💡 Additional information
N/A