Skip to content

Rename the equalMarkup Chai assertion to the toEqualMarkup Vitest matcher#1412

Closed
pomek wants to merge 7 commits into
masterfrom
ci/4595-to-equal-markup-vitest-matcher
Closed

Rename the equalMarkup Chai assertion to the toEqualMarkup Vitest matcher#1412
pomek wants to merge 7 commits into
masterfrom
ci/4595-to-equal-markup-vitest-matcher

Conversation

@pomek

@pomek pomek commented Jul 6, 2026

Copy link
Copy Markdown
Member

🚀 Summary

Renames the equalMarkup Chai assertion to the toEqualMarkup() Vitest matcher (matching the Vitest naming style) and removes the unused attribute Chai assertion.

The matcher is registered in a Vitest setup file via expect.extend( { toEqualMarkup } ), importing it from the main entry point of @ckeditor/ckeditor5-dev-tests. To make that import safe in a browser context, the main entry point now exposes only the matcher — the test runner tasks and parseArguments() are no longer exported (the binary scripts import them directly and remain the public interface of the runners). The package ships the vitest type augmentation (lib/vitest/matchers.d.ts), so consumers get toEqualMarkup() typings out of the box.


📌 Related issues


💡 Additional information

@pomek pomek changed the title Introduce the toEqualMarkup Vitest matcher and remove the attribute Chai assertion Rename the equalMarkup Chai assertion to the toEqualMarkup Vitest matcher Jul 6, 2026
@pomek pomek changed the base branch from master-v57 to master July 6, 2026 12:55
@pomek

pomek commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Superseded by #1413 — both changes were combined there (the matcher migration and the runner removal are tightly coupled), and the PR now targets master directly. Closing.

@pomek pomek closed this Jul 6, 2026
@pomek pomek deleted the ci/4595-to-equal-markup-vitest-matcher branch July 6, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant