Rename the equalMarkup Chai assertion to the toEqualMarkup Vitest matcher#1412
Closed
pomek wants to merge 7 commits into
Closed
Rename the equalMarkup Chai assertion to the toEqualMarkup Vitest matcher#1412pomek wants to merge 7 commits into
pomek wants to merge 7 commits into
Conversation
…ibute Chai assertion.
7e72fc1 to
08ae0a2
Compare
…rs can be imported from it.
Member
Author
|
Superseded by #1413 — both changes were combined there (the matcher migration and the runner removal are tightly coupled), and the PR now targets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Renames the
equalMarkupChai assertion to thetoEqualMarkup()Vitest matcher (matching the Vitest naming style) and removes the unusedattributeChai assertion.The matcher is registered in a Vitest setup file via
expect.extend( { toEqualMarkup } ), importing it from the main entry point of@ckeditor/ckeditor5-dev-tests. To make that import safe in a browser context, the main entry point now exposes only the matcher — the test runner tasks andparseArguments()are no longer exported (the binary scripts import them directly and remain the public interface of the runners). The package ships thevitesttype augmentation (lib/vitest/matchers.d.ts), so consumers gettoEqualMarkup()typings out of the box.📌 Related issues
💡 Additional information
attributeassertion had zero call sites inckeditor5andckeditor5-commercial, hence it is removed instead of migrated (a deviation from the issue's DoD).equalMarkupChai factory stays in this PR — the Karma entry-file generator still registers it. It is removed together with the Karma runner in Migrate the testing environment to Vitest: rename equalMarkup to toEqualMarkup and remove the automated test runner #1413.