Skip to content

Fix cleanup job: Remove all droplets in state "failed" #5254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jochenehret wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix cleanup job: Remove all droplets in state "failed" #5254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/jobs/runtime/expired_blob_cleanup.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class ExpiredBlobCleanup < VCAP::CloudController::Jobs::CCJob
def perform
logger.info('Deleting package and droplet blobs that are expired or failed')

DropletModel.where(state: [DropletModel::EXPIRED_STATE, DropletModel::FAILED_STATE]).exclude(droplet_hash: nil).each do |droplet|
DropletModel.where(state: [DropletModel::EXPIRED_STATE, DropletModel::FAILED_STATE]).each do |droplet|
enqueue_droplet_delete_job(droplet.guid)
end

Expand Down
4 changes: 2 additions & 2 deletions spec/unit/jobs/runtime/expired_blob_cleanup_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module Jobs::Runtime
end

it 'enqueues a deletion job only for buildpack droplets' do
expect { job.perform }.to change(Delayed::Job, :count).by(1)
expect { job.perform }.to change(Delayed::Job, :count).by(2)
expect(Delayed::Job.last.handler).to include('DeleteExpiredDropletBlob')
end
end
Expand All @@ -35,7 +35,7 @@ module Jobs::Runtime
end

it 'enqueues a deletion job only for buildpack droplets' do
expect { job.perform }.to change(Delayed::Job, :count).by(1)
expect { job.perform }.to change(Delayed::Job, :count).by(2)
expect(Delayed::Job.last.handler).to include('DeleteExpiredDropletBlob')
end
end
Expand Down
Loading