Require the stratos PR aggregate check instead of each suite job#1548
Open
nabramovitz wants to merge 1 commit into
Open
Require the stratos PR aggregate check instead of each suite job#1548nabramovitz wants to merge 1 commit into
nabramovitz wants to merge 1 commit into
Conversation
The per-job contexts blocked docs-only PRs: when the frontend matrix is skipped, its per-package required contexts never report and stay 'expected' (seen on cloudfoundry/stratos#5563). PR Quality Gate aggregates lint/frontend/backend/build/website results, reports on every PR, and fails on any failed or cancelled job. STB Tests runs from a separate workflow and remains individually required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
For
cloudfoundry/stratos(develop/main), replace the ten per-job required status checks with the repo's aggregate check:EasyCLA(unchanged)PR Quality Gate(new — replaces Lint Check, the sevenFrontend Tests (package)matrix contexts, Backend Tests, Build Check)STB Tests(unchanged — runs from a separate workflow not covered by the aggregate)Why
Stratos recently added a docs-only fast path to its PR workflow (cloudfoundry/stratos#5564, #5566): PRs touching only
docs//website/skip the heavy test suite via job-levelif:gates. Single skipped jobs report askippedconclusion and satisfy branch protection, but a skipped matrix job never expands — its per-package contexts never report, and the merge blocks with7 of 12 required status checks are expected(observed on cloudfoundry/stratos#5563, a one-file docs change).PR Quality Gateis stratos' aggregate job: it runs on every PR (if: always()), inspects the result of lint, all frontend matrix shards, backend tests, build check, and website build, and fails on anyfailureorcancelledresult while acceptingskipped(the deliberate fast-path outcome). Requiring the aggregate instead of each job is the standard resolution for required-check + conditional-matrix workflows, and lets stratos revert an interim workaround (cloudfoundry/stratos#5567) that spins up no-op matrix shards purely so their contexts report.Risk
Low. Enforcement is equivalent: any suite failure fails the aggregate and blocks the merge; the only behavioral change is that legitimately-skipped paths no longer deadlock. Same config mechanism as #1537.