fix(cache): re-enable Coil disk cache to stop image re-download on launch#1021
Merged
Conversation
…unch Disabling Coil's disk cache (diskCachePolicy DISABLED) made its NetworkFetcher stamp Cache-Control: no-cache, no-store on every image request, which forced OkHttp's cache to neither read nor write responses — so every image was fully re-downloaded on each cold start. Replace the OkHttp http_image_cache with Coil's own DiskCache as the single persistent image layer. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling Coil's disk cache (diskCachePolicy DISABLED) made its NetworkFetcher stamp Cache-Control: no-cache, no-store on every image request, which forced OkHttp's cache to neither read nor write responses — so every image was fully re-downloaded on each cold start. Replace the OkHttp http_image_cache with Coil's own DiskCache as the single persistent image layer.