fix(accesskey): make export dimensions compile-time constants#1039
Merged
Conversation
The access key export dimensions (targetWidth/Height, logo, QR, text offsets)
were instance `val`s, read by createBitmapForExport on dispatchers.IO. That
work is kicked off from the init{} flow collector before the constructor
finishes initializing the fields, publishing a half-built `this` to a
background thread with no happens-before. The IO thread could then observe a
field as its default 0, throwing "IllegalArgumentException: width and height
must be > 0" — but only on release/R8 builds (isDebuggable=false); debug and
minified-debug masked it via un-optimized codegen and timing.
Promote the dimensions to `const val` in a companion object so kotlinc inlines
them at every use site — no instance fields left to race on. Also switch the
entropy flow to mapNotNull.
Refs Bugsnag 6a457e5e.
Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The access key export dimensions (targetWidth/Height, logo, QR, text offsets) were instance
vals, read by createBitmapForExport on dispatchers.IO. That work is kicked off from the init{} flow collector before the constructor finishes initializing the fields, publishing a half-builtthisto a background thread with no happens-before. The IO thread could then observe a field as its default 0, throwing "IllegalArgumentException: width and height must be > 0" — but only on release/R8 builds (isDebuggable=false); debug and minified-debug masked it via un-optimized codegen and timing.Promote the dimensions to
const valin a companion object so kotlinc inlines them at every use site — no instance fields left to race on. Also switch the entropy flow to mapNotNull.Refs Bugsnag 6a457e5e.