fix: Use os.path.join for path construction in folder_searcher#718
Open
sentry[bot] wants to merge 1 commit into
Open
fix: Use os.path.join for path construction in folder_searcher#718sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLI-EY, a
TypeError: unsupported operand type(s) for /: 'PosixPath' and 'str'that occurred incodecov_cli/helpers/folder_searcher.py.The root cause was identified as an incompatibility with
pathlib.Path.__truediv__(the/operator for path joining) when running in a PyInstaller-frozen CPython 3.9.5 environment. Specifically,pathlib's internal validation usingos.fspath()on the string operand failed, causing__truediv__to returnNotImplementedand Python to raise theTypeError.The issue was triggered by the
gcovplugin, which is part of the default plugin list and unconditionally callssearch_filesover the project root, even when only explicit non-gcov coverage files are specified.To fix this, the three occurrences of
pathlib.Path(dirpath) / nameinfolder_searcher.pyhave been replaced withpathlib.Path(os.path.join(str(dirpath), name)). This change bypasses the problematicpathlib.__truediv__operator by using the standardos.path.joinfor string-based path concatenation, then converting the result back to apathlib.Pathobject. This ensures compatibility within the frozen executable environment.Fixes CLI-EY