fix: strip whitespace from CODECOV_TOKEN in Authorization header - #742
Open
sentry[bot] wants to merge 1 commit into
Open
fix: strip whitespace from CODECOV_TOKEN in Authorization header#742sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
InvalidHeadererror (CLI-1R) that occurs when theCODECOV_TOKENenvironment variable contains trailing whitespace, such as a newline character. This is common when the token is sourced from a CI secret or file.The
requestslibrary rejects header values containing reserved characters like newlines. Previously, theget_token_headerandget_token_header_or_failfunctions incodecov_cli/helpers/request.pywould interpolate the token directly into theAuthorizationheader without sanitization.This fix modifies both functions to call
.strip()on thetokenbefore constructing the header. This ensures that any leading or trailing whitespace is removed, preventing theInvalidHeadererror. Since Codecov tokens are typically UUIDs and do not legitimately contain surrounding whitespace, this change does not compromise security or functionality.Fixes CLI-1R