Fix: web preview readout showed a phantom streak line#16
Merged
Conversation
The preview's stand-in readout listed five lines — repos, stars earned, followers, following, and streak. CI only ever writes the first four; the streak is the 🔥 badge, not a readout line. So the preview drew a fifth row that no real banner has, which is exactly the "why does the web show a streak the actual doesn't" mismatch. Dropped it, so the preview readout is the same four lines CI produces, in the same order. The streak badge itself is unchanged and correct: like the sample contribution year, it shows a plausible number so you can see the badge; CI fills your real one, and it hides itself when that's zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser preview's stand-in readout listed five lines —
repos,stars earned,followers,following, andstreak. CI only ever writes the firstfour; the streak is the 🔥 badge, not a readout line. So the preview drew a fifth
row no real banner has, which is the reported "the web shows a streak the actual
doesn't" mismatch.
Fix
Drop
streak:4fromSAMPLE_STATS(web/src/lib/sample.ts). The preview readoutis now the same four lines CI produces, in the same order — the structure matches
the real output. The sample values (71, 82, …) stay plausible placeholders on
purpose; CI swaps them for the real ones.
The streak badge is unchanged and correct: like the sample contribution year, it
shows a plausible number so the badge is visible; CI fills the real one, and it
hides itself when that's zero.
tsc --noEmitclean.