Skip to content

fix(EC-1912): validate in-toto statement type in bundle attestation path #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BohdanMar wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −0
Open

fix(EC-1912): validate in-toto statement type in bundle attestation path #3418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/attestation/attestation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,11 @@ func ProvenanceFromBundlePayload(sig oci.Signature, dsseJSON []byte) (Attestatio
return nil, fmt.Errorf("malformed bundle attestation: %w", err)
}

if statement.Type != in_toto.StatementInTotoV1 &&
statement.Type != in_toto.StatementInTotoV01 {
return nil, fmt.Errorf("unsupported attestation type: %s", statement.Type)
}

signatures, err := createEntitySignatures(sig, payload)
if err != nil {
return nil, fmt.Errorf("cannot create signed entity: %w", err)
Expand Down
22 changes: 22 additions & 0 deletions internal/attestation/attestation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ func TestProvenanceFromSignature(t *testing.T) {
snaps.MatchJSON(t, string(p.Statement()))
})
}

}

func TestProvenance_Type(t *testing.T) {
Expand Down Expand Up @@ -284,6 +285,27 @@ func TestProvenanceFromBundlePayload(t *testing.T) {
base64.StdEncoding.EncodeToString([]byte(`not-json`))),
expectErr: "malformed bundle attestation",
},
{
name: "unsupported attestation type",
setup: func(l *mockSignature) {},
dsseJSON: fmt.Sprintf(`{"payloadType":"application/vnd.in-toto+json","signatures": [%s], "payload": "%s"}`,
sig1, encode(`{
"_type": "https://bogus.example.io/Statement/v9.9",
"predicateType": "https://cool-type.example.io/Amazing/v2.0",
"predicate": {}
}`)),
expectErr: "unsupported attestation type: https://bogus.example.io/Statement/v9.9",
},
{
name: "empty attestation type",
setup: func(l *mockSignature) {},
dsseJSON: fmt.Sprintf(`{"payloadType":"application/vnd.in-toto+json","signatures": [%s], "payload": "%s"}`,
sig1, encode(`{
"predicateType": "https://cool-type.example.io/Amazing/v2.0",
"predicate": {}
}`)),
expectErr: "unsupported attestation type: ",
},
}

for _, c := range cases {
Expand Down
Loading