fix(bulk-operations): display taxonomy error messages in progress-manager mode - #319
Closed
harshitha-cstk wants to merge 1 commit into
Closed
fix(bulk-operations): display taxonomy error messages in progress-manager mode#319harshitha-cstk wants to merge 1 commit into
harshitha-cstk wants to merge 1 commit into
Conversation
…ager mode In progress-manager mode (log.showConsoleLogs=false) the logger suppresses errors on the console, so bulk-taxonomies failures — including setup errors thrown in init() like "We can't find that Stack" — left a blank screen. Add a surfaceError helper wired into run()'s catch (operation-phase errors) and a catch() override (init-phase errors that never reach run()). It prints the message via cliux only when console logging is suppressed, and skips DisplayedError to avoid duplicating messages validators already print. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
Consider reviewing these vulnerabilities when fixes become available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In progress-manager mode (
log.showConsoleLogs=false), the cli-utilities logger suppresses errors on the console. As a result,cm:stacks:bulk-taxonomiesfailures — including setup errors thrown ininit()/setupStack()such as "We can't find that Stack" — left the user with a blank screen.Why taxonomies specifically
bulk-assets/bulk-entriesalways reachrecordModuleSummary(), and theCLIProgressManagersummary prints independently of the logger's console suppression — so those commands always show feedback.bulk-taxonomiesskips the summary on error (the error bubbles past it) and the error itself is swallowed by the suppressed logger → nothing on screen.Change
Scoped to
bulk-taxonomies.ts:surfaceError()helper that prints the error viacliuxonly when console logging is suppressed (no-op otherwise, since the logger already prints it), and skipsDisplayedError(validators print those directly).run()'s catch (operation-phase errors) and a newcatch()override (init-phase errors that never reachrun()).Notes
showConsoleLogs=true.🤖 Generated with Claude Code