Skip to content

strerror is now thread safe #8648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrew-aitchison wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

strerror is now thread safe #8648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions addons/threadsafety.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@
'race:stdin',
'race:stdout',
'race:streams',
'race:strerror',
'race:strsignal',
'race:strtok',
'race:tmbuf',
Expand Down Expand Up @@ -261,7 +260,6 @@
'siginterrupt',
'sleep',
'srand48',
'strerror',
'strsignal',
'strtok',
'tmpnam',
Expand Down
8 changes: 4 additions & 4 deletions test/cli/other_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,9 +458,9 @@ def test_addon_threadsafety(tmpdir):
test_file = os.path.join(tmpdir, 'test.cpp')
with open(test_file, 'wt') as f:
f.write("""
extern const char* f()
extern void f()
{
return strerror(1);
elf_fill(1);
}
""")

Expand All @@ -472,7 +472,7 @@ def test_addon_threadsafety(tmpdir):
assert lines == [
'Checking {} ...'.format(test_file)
]
assert stderr == '{}:4:12: warning: strerror is MT-unsafe [threadsafety-unsafe-call]\n'.format(test_file)
assert stderr == '{}:4:5: warning: elf_fill is MT-unsafe [threadsafety-unsafe-call]\n'.format(test_file)


def test_addon_naming(tmpdir):
Expand Down Expand Up @@ -4749,4 +4749,4 @@ def test_ipc_inline_suppressions(tmp_path):
stdout_lines = stdout.splitlines()
stdout_lines.sort()
assert stdout_lines == stdout_exp
assert stderr.splitlines() == []
assert stderr.splitlines() == []
Loading