Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| Settings(Settings&&) noexcept; | ||
| Settings& operator=(Settings&&) noexcept; | ||
| Settings(Settings&&) CPPCHECK_NOEXCEPT; |
| Settings(Settings&&) noexcept; | ||
| Settings& operator=(Settings&&) noexcept; | ||
| Settings(Settings&&) CPPCHECK_NOEXCEPT; | ||
| Settings& operator=(Settings&&) CPPCHECK_NOEXCEPT; |
| Settings(Settings&&) noexcept; | ||
| Settings& operator=(Settings&&) noexcept; | ||
| Settings(Settings&&) CPPCHECK_NOEXCEPT; | ||
| Settings& operator=(Settings&&) CPPCHECK_NOEXCEPT; |
|
|
||
| strategy: | ||
| matrix: | ||
| image: ["gcc:6.5", "gcc:7.5", "gcc:8.5", "gcc:9.5"] |
There was a problem hiding this comment.
These images are way too big (500+ MB) to be used in the CI.
I would also prefer an actual distro as there are several other moving parts in those which might cause issues (mainly CMake).
There was a problem hiding this comment.
And it should be sufficient to test the minimum support version.
There was a problem hiding this comment.
I would also prefer an actual distro as there are several other moving parts in those which might cause issues (mainly CMake).
And the limitations of GitHub runners which will no longer allow us to run certain distro versions. We should probably apply the same we do for Python - specify the oldest what we can reasonable use in the CI as the actual minimum - even if it might be EOL/EOS.
| - image: "alpine:3.23" | ||
| with_gui: false # it appears FindQt6.cmake is not provided by any package | ||
| full_build: false # FIXME: test-signalhandler.cpp fails to build since feenableexcept() is missing | ||
| - image: "oraclelinux:8" |
There was a problem hiding this comment.
Please use oraclelinux:8-slim for a smaller base image.
| strategy: | ||
| matrix: | ||
| image: ["ubuntu:24.04", "ubuntu:25.10", "alpine:3.23"] | ||
| image: ["ubuntu:24.04", "ubuntu:25.10", "alpine:3.23", "oraclelinux:8"] |
There was a problem hiding this comment.
Please use oraclelinux:8-slim for a smaller base image.
| /** List of registered check classes. This is used by Cppcheck to run checks and generate documentation */ | ||
| CPPCHECKLIB const std::list<Check *>& get(); | ||
| }; | ||
| } |
There was a problem hiding this comment.
I am curious why we did not see this warning in the CI before.
| // Hack to workaround GCC bug. | ||
| // Details: https://trac.cppcheck.net/ticket/14850 | ||
| // seen on: | ||
| // oraclelinux:8, g++-8.5 | ||
| // ubuntu:20.04, g++-9.4.0 |
There was a problem hiding this comment.
This comment can be adjusted to g++ before 10.x as it is not distribution bound.
3 participants
No description provided.