Fix 1859#1860
Merged
Merged
Conversation
…1859) The post-merge 26.6.1 dev release failed strict fileset validation with a missing pypy311-win-amd64 wheel. Two defects: 1. build-all (justfile) swallowed per-interpreter build failures: a failing 'just build <venv>' did not fail the recipe (no set -e; the loop ended in 'ls'), so the Windows wheels job went green while silently omitting a wheel. Now build-all attempts all interpreters but exits non-zero if any failed, naming them - the same false-green class as crossbario#1856 / zlmdb#116. 2. The PyPy/Windows build aborted installing the core dependency cbor2: cbor2 6.x is Rust/pyo3-only (no PyPy/Windows wheel, and the pure-Python fallback + CBOR2_BUILD_C_EXTENSION toggle were removed in the 6.0 rewrite), so pip built from sdist and the pyo3 link failed (unresolved PyPyModule_FromDefAndSpec2, a known pyo3-on-PyPy/Windows limitation). Cap cbor2 < 6 *only* on PyPy/Windows via environment markers - the 5.x line ships a pure-Python wheel and runs at near-native speed on PyPy - while keeping cbor2 6.x everywhere else. PyPy/Windows is kept as a build target and a required release artifact; the native NVX build is attempted there (it was never reached before, since cbor2 aborted first). If NVX itself turns out not to compile on PyPy/Windows, the now-loud build-all will surface it and we retreat to excluding PyPy/Windows. Note: This work was completed with AI assistance (Claude Code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1859