Update email wording for re-registration email to note removal of MFA

[landonshumway-ia]

When a SSN is corrected for a practitioner using the previousSSN feature, if the practitioner was previously registered, their old Cognito account is deleted and an email is sent notifying the practitioner that they need to re-register. The JCC compact EDs have requested that we update the wording in that email to note that the practitioner will need to remove their old MFA configuration that was used to login to CompactConnect under their old account so that they are aware that the codes generated for their previous account will no longer work.

Testing List

• yarn test:unit:all should run without errors or warnings
• yarn serve should run without errors or warnings
• yarn build should run without errors or warnings
• For API configuration changes: CDK tests added/updated in backend/compact-connect/tests/unit/test_api.py
• For API endpoint changes: OpenAPI spec updated to show latest endpoint configuration run compact-connect/bin/download_oas30.py
• Code review

Closes #1793

Summary by CodeRabbit

• Documentation
  • Updated SSN-correction re-registration email instructions to clarify MFA setup requirements.
  • Added guidance to remove the existing compact entry from the MFA app.
  • Highlighted that the registration link is time-sensitive.
  • Confirmed that active privileges remain unaffected.

[coderabbitai]

Warning

Review limit reached

@landonshumway-ia, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 17af7916-6f4c-4b45-940e-6d645792a09e

📥 Commits

Reviewing files that changed from the base of the PR and between 5b28bb9 and ff28ce9.

📒 Files selected for processing (1)

• .github/workflows/check-compact-connect.yml

📝 Walkthrough

Walkthrough

The SSN-correction re-registration email now explains MFA reconfiguration, removal of the previous MFA entry, unaffected active privileges, and the time-sensitive registration link.

Changes

SSN Correction Re-registration Email

Layer / File(s)	Summary
Update re-registration email wording backend/compact-connect/lambdas/nodejs/lib/email/email-notification-service.ts	The email instructs recipients to repeat MFA setup, delete the existing compact entry, and promptly use the time-sensitive registration link. It retains the clarification that active privileges remain unaffected.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the email wording change for removing old MFA configuration.
Description check	✅ Passed	The description explains the change, provides the testing checklist, and references issue #1793; the missing headings are non-critical.
Linked Issues check	✅ Passed	The email update directly satisfies issue #1793 by telling practitioners to remove the old MFA configuration after SSN correction.
Out of Scope Changes check	✅ Passed	The single-line change is limited to the re-registration email wording and matches the linked issue objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Fix failing CI checks

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

backend/compact-connect/lambdas/nodejs/lib/email/email-notification-service.ts (1)

458-458: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Assert the updated body in the SSN-correction email test.

backend/compact-connect/lambdas/nodejs/tests/email-notification-service.test.ts:803-852 checks delivery, recipients, HTML presence, and subject, but not the body text. Add assertions for MFA removal, invalid old codes, active privileges, and the time-sensitive registration link.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@backend/compact-connect/lambdas/nodejs/lib/email/email-notification-service.ts`
at line 458, Update the SSN-correction email test in the relevant
email-notification-service test case to assert the generated body includes MFA
removal instructions, invalidation of old codes, preservation of active
privileges, and the time-sensitive registration link. Reuse the existing body
extraction and registration URL symbols, while keeping the current delivery,
recipient, HTML, and subject assertions unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@backend/compact-connect/lambdas/nodejs/lib/email/email-notification-service.ts`:
- Line 458: Update the bodyText message in the email notification service to
consistently describe the registrationUrl as a registration link rather than an
account-reset link, and explicitly state that the previous account was deleted
so its existing MFA codes will no longer work and must be removed before
registering again.

---

Nitpick comments:
In
`@backend/compact-connect/lambdas/nodejs/lib/email/email-notification-service.ts`:
- Line 458: Update the SSN-correction email test in the relevant
email-notification-service test case to assert the generated body includes MFA
removal instructions, invalidation of old codes, preservation of active
privileges, and the time-sensitive registration link. Reuse the existing body
extraction and registration URL symbols, while keeping the current delivery,
recipient, HTML, and subject assertions unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: de7a809e-976e-41f6-91c1-3962b179ee98

📥 Commits

Reviewing files that changed from the base of the PR and between 8da34f7 and 5b28bb9.

📒 Files selected for processing (1)

• backend/compact-connect/lambdas/nodejs/lib/email/email-notification-service.ts

[landonshumway-ia]

Screenshot of generated template

[landonshumway-ia]

@jlkravitz This is ready for your review. Note the linter is failing because of an dependency that has been updated in #1789

[jlkravitz]

@isabeleliassen Good to merge!