feat(post): "For you" feed below comments on the post page#6174
Open
tsahimatsliah wants to merge 4 commits into
Open
feat(post): "For you" feed below comments on the post page#6174tsahimatsliah wants to merge 4 commits into
tsahimatsliah wants to merge 4 commits into
Conversation
Adds a personalized discovery feed under the comments on the article post page to keep readers exploring. Logged-in users get the personalized feedV2; anonymous users get the popular anonymous feed. The feed renders as a grid by overriding the post route's forced list layout (feedName -> Popular, insaneMode off, FeedLayoutProvider). Gated behind the new `post_page_feed` flag (default on for now; flip to off after review) and limited to standard reading post types (article, video, share, freeform, welcome, collection). First of three PRs split out of #6130. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Ship the post-page "For you" feed disabled by default; it is enabled via the post_page_feed feature flag. Tests enable the flag explicitly to exercise the visible behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The feed below comments reused SharedFeedPage.Popular, so its impressions, clicks, votes and FinishFeed/FeedEmpty events were attributed to the real Popular feed — polluting its metrics and making the gated feature impossible to measure. Introduce OtherFeedPage.PostPageFeed, register it in FeedLayoutMobileFeedPages (grid on laptop, list on mobile preserved), and use it as the feed name and query key so all events are attributable to this surface. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
@claude fix the build and make sure all are green including circleCI |
Contributor
|
Claude finished @tsahimatsliah's task in 3m 42s —— View job Build & CI status
Good news — everything is already green on the current HEAD ( Remote checks (all passing for
|
| Check | Result |
|---|---|
CircleCI build |
✅ pass (6m17s) |
CircleCI build_extension |
✅ pass |
CircleCI install_deps |
✅ pass |
CircleCI lint_shared |
✅ pass |
CircleCI test_shared |
✅ pass |
CircleCI test_webapp |
✅ pass |
CircleCI test_extension |
✅ pass |
CircleCI typecheck_strict_changed |
✅ pass |
| Vercel – daily-webapp | ✅ pass |
| assign-preview-domain (GH Actions) | ✅ pass |
| license/cla | ✅ pass |
Local verification (fresh checkout)
node scripts/typecheck-strict-changed.js→ passed (Changed TypeScript files passed strict migration guard.)- ESLint on all changed
sharedfiles → 0 errors jest __tests__/PostPage.tsx→ 48/48 passed, including the 4 newpost page feedtests
The two most recent commits on the branch (113ec9a default the flag to off, 35b8f2e give the feed its own analytics identity) already brought CI to a fully green state, so there was nothing left to fix. If you saw a red check earlier, it was on a previous commit that has since been superseded.
· branch claude/gifted-wilson-77f08c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of three PRs split out of the #6130 discovery mockup, rebuilt cleanly on
main. Adds a personalized "For you" feed below the comments on the article post page to keep readers exploring after finishing a post.PostPageFeed(packages/shared/src/components/post/PostPageFeed.tsx) — a centered "For you" header + the personalized feed. Logged-in users getfeedV2; anonymous users get the popular anonymous feed.feedName === OtherFeedPage.Post), so the feed is wrapped in a scope that overridesActiveFeedNameContexttoPopular, setsinsaneMode: false, and suppliesFeedLayoutProvider— yielding a grid on laptop while collapsing to a list on mobile.feedQueryKey('post-page-feed'suffix) so it never collides with the home Popular feed cache.usePostPageFeed— eligibility (article, video, share, freeform, welcome, collection) gated byuseConditionalFeature.Flag
post_page_feed, defaulttruefor now so it can be reviewed. There's aTODOinfeatureManagement.tsto flip the default tofalseonce approved.Follow-ups
Test plan
/posts/<id>— grid feed below comments on laptop, single-column list on mobile🤖 Generated with Claude Code
Preview domain
https://claude-gifted-wilson-77f08c.preview.app.daily.dev