Skip to content

Fix RabbitMQ pubsub exchangeKind allowed values (add direct, headers)#5228

Merged
alicejgibbons merged 3 commits into
dapr:v1.18from
MyMirelHub:fix-rabbitmq-exchange-kinds
Jul 20, 2026
Merged

Fix RabbitMQ pubsub exchangeKind allowed values (add direct, headers)#5228
alicejgibbons merged 3 commits into
dapr:v1.18from
MyMirelHub:fix-rabbitmq-exchange-kinds

Conversation

@MyMirelHub

@MyMirelHub MyMirelHub commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description

The RabbitMQ pub/sub reference page lists only fanout and topic as allowed values for exchangeKind, but the component actually accepts four exchange kinds. From exchangeKindValid in components-contrib:

func exchangeKindValid(kind string) bool {
	return kind == amqp.ExchangeFanout || kind == amqp.ExchangeTopic || kind == amqp.ExchangeDirect || kind == amqp.ExchangeHeaders
}

This updates the exchangeKind row to also list direct and headers.

Docs for dapr/components-contrib#4427

@MyMirelHub
MyMirelHub requested review from a team as code owners June 29, 2026 17:50
The RabbitMQ pubsub component accepts four exchange kinds (fanout,
topic, direct, headers) per exchangeKindValid in components-contrib,
but the reference table only listed fanout and topic. Add the missing
direct and headers values.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
@MyMirelHub
MyMirelHub force-pushed the fix-rabbitmq-exchange-kinds branch from a600752 to 1f459a9 Compare June 29, 2026 17:51

@alicejgibbons alicejgibbons left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@marcduiker marcduiker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alicejgibbons
alicejgibbons merged commit d7355f6 into dapr:v1.18 Jul 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants