Skip to content

fix: make staging path-traversal check separator-aware (fail-open on Windows) #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mani-mathur-arch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make staging path-traversal check separator-aware (fail-open on Windows) #422

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e509b3a
fix: make staging path-traversal check separator-aware
mani-mathur-arch Jul 22, 2026
46ea4d9
Merge branch 'main' into mani-mathur_data/mani/fix-staging-path-trave…
mani-mathur-arch Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,15 @@ func localPathIsAllowed(stagingAllowedLocalPaths []string, localFile string) boo
if err != nil {
return false
}
if !strings.Contains(relativePath, "../") {
// localFile is inside the allowed dir iff the relative path does not climb
// out of it, i.e. it is neither ".." itself nor starts with "..<sep>".
// filepath.Rel returns OS-native separators ("../x" on unix, "..\\x" on
// windows), so this must compare against filepath.Separator rather than a
// hard-coded "../" — the latter never matches the windows "..\\" form and
// silently allows an escaping path (a fail-open path-traversal check on
// windows). Using the "../" prefix (not a Contains) also avoids treating a
// sibling like "..foo" as an escape.
if relativePath != ".." && !strings.HasPrefix(relativePath, ".."+string(filepath.Separator)) {
return true
}
}
Expand Down
Loading