detect conflicting env keys set by enterprise settings - #250
Open
asujithan wants to merge 2 commits into
Open
Conversation
Comment on lines
+162
to
+166
| "ANTHROPIC_DEFAULT_OPUS_MODEL", | ||
| "ANTHROPIC_DEFAULT_SONNET_MODEL", | ||
| "ANTHROPIC_DEFAULT_HAIKU_MODEL", | ||
| "ANTHROPIC_DEFAULT_FABLE_MODEL", | ||
| ) |
Collaborator
There was a problem hiding this comment.
why do we need to include these? shouldn't ANTHROPIC_MODEL be sufficient, because that is the one that we launch with?
| "auth — you'd be billed for API usage instead of using your subscription. " | ||
| "Remove the 'apiKeyHelper' from that file (or ask your admin to) before " | ||
| "running relayed auth. Not starting Claude Code." | ||
| "Enterprise managed settings is present, which Claude Code always " |
Collaborator
There was a problem hiding this comment.
Suggested change
| "Enterprise managed settings is present, which Claude Code always " | |
| "Enterprise managed settings are present, which Claude Code always " |
Comment on lines
+857
to
+859
| f"Default models {models} are set in your enterprise managed settings " | ||
| f"({managed_path}). Remove those keys if the default models are deprecated." | ||
| ) |
Collaborator
There was a problem hiding this comment.
what about
f"Default models {models} are set in your enterprise-managed settings "
f"({managed_path}) and may override ucode settings. Remove these entries if "
f"you encounter issues."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds warning message when default models are set in the managed/enterprise settings which would override what's in ucode-settings. Blocking error is thrown if ANTHROPIC_BASE_URL or ANTHROPIC_CUSTOM_HEADERS is set in the managed settings since that will prevent claude terminal from being started with Claude Max/Enterprise subscription.