Fix DDS_SCHEDULER build consistency and dtest -r reporting.#201
Open
tameware wants to merge 3 commits into
Open
Fix DDS_SCHEDULER build consistency and dtest -r reporting.#201tameware wants to merge 3 commits into
tameware wants to merge 3 commits into
Conversation
Propagate scheduler define through :dds to fix Scheduler ODR/crash; use SolveAllBoards for parallel solve timing; clarify calc has no per-board data. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Propagates the DDS_SCHEDULER compile define through the core :dds Bazel targets to avoid mixed-define builds (and associated ODR/runtime issues), and adjusts dtest to use the library batch solver plus clearer -r output when per-board timing isn’t available.
Changes:
- Add
DDS_SCHEDULER_DEFINEtolocal_definesfor:ddsand:testable_dds*Bazel targets. - Update
dtestsolve loop to callSolveAllBoards()for the parallel path. - Refine
dtest -rmessaging when per-board timing data is not available (notably forcalc).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| library/tests/testcommon.cpp | Improves -r reporting when scheduler timing data isn’t available. |
| library/tests/loop.cpp | Switches parallel solve path to SolveAllBoards(). |
| library/src/init.cpp | Removes scheduler debug-file init hook from InitDebugFiles(). |
| library/src/BUILD.bazel | Propagates DDS_SCHEDULER_DEFINE into core library/testable library targets. |
Zero hands[]/group[] timing fields in Reset() and skip group/per-hand stats unless populated by the GetNumber dispatcher path. Co-authored-by: Cursor <cursoragent@cursor.com>
…timing. Add worker_cap to solve_all_boards_n/pbn_n so loop_solve passes options.num_threads_ instead of always using hardware concurrency. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate scheduler define through :dds to fix Scheduler ODR/crash; use SolveAllBoards for parallel solve timing; clarify calc has no per-board data.
Test with
bazel build --define=scheduler=true //library/tests:dtestbazel-bin/library/tests/dtest -f hands/list10.txt -r