Feature: add row-major in DensityMatrix::_DMK#7447
Conversation
|
Can you explain when do we need row-major DMK? |
|
As a PR reviewer, we often passively receive new feature submissions from developers without clear explanations of their necessity. This PR introduces an extra logic layer to distinguish row-major and column-major orders, which greatly complicates the existing code. For such pull requests, I always question whether it is reasonable to add this complexity to the original implementation. |
At present, DMK uses Fortran-style column-major order. This poses unnecessary difficulties for developers. |
now DensityMatrix::_DMK supports both row-major and col-major