Skip to content

fix(config): bump default persistent home init container memory limit… #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkwon17 merged 1 commit into from
Jun 16, 2026
+9 −9
Merged

fix(config): bump default persistent home init container memory limit… #1644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/controller/v1alpha1/devworkspaceoperatorconfig_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ type WorkspaceConfig struct {
SchedulerName string `json:"schedulerName,omitempty"`
// DefaultContainerResources defines the resource requirements (memory/cpu limit/request) used for
// container components that do not define limits or requests. In order to not set a field by default,
// the value "0" should be used. By default, the memory limit is 128Mi and the memory request is 64Mi.
// the value "0" should be used. By default, the memory limit is 256Mi and the memory request is 128Mi.

@rohanKanojia rohanKanojia Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you've modified CRD types you'd need to run this command so that changes are reflected in deploy/ manifests:

make generate_all

You don't need to manually modify deepcopy.go or any files in deploy/. When I ran the above-mentioned command, i saw these files being modified:

        modified:   apis/controller/v1alpha1/zz_generated.deepcopy.go
        modified:   deploy/bundle/manifests/controller.devfile.io_devworkspaceoperatorconfigs.yaml
        modified:   deploy/deployment/kubernetes/combined.yaml
        modified:   deploy/deployment/kubernetes/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml
        modified:   deploy/deployment/openshift/combined.yaml
        modified:   deploy/deployment/openshift/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml

// No CPU limit or request is added by default.
DefaultContainerResources *corev1.ResourceRequirements `json:"defaultContainerResources,omitempty"`
// ContainerResourceCaps defines the maximum resource requirements enforced for workspace
Expand Down
2 changes: 1 addition & 1 deletion deploy/bundle/manifests/controller.devfile.io_devworkspaceoperatorconfigs.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion deploy/deployment/kubernetes/combined.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...s/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion deploy/deployment/openshift/combined.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...t/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion deploy/templates/crd/bases/controller.devfile.io_devworkspaceoperatorconfigs.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/config/defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ var defaultConfig = &v1alpha1.OperatorConfiguration{
},
DefaultContainerResources: &corev1.ResourceRequirements{
Limits: corev1.ResourceList{
corev1.ResourceMemory: resource.MustParse("128Mi"),
corev1.ResourceMemory: resource.MustParse("256Mi"),
},
Requests: corev1.ResourceList{
corev1.ResourceMemory: resource.MustParse("64Mi"),
corev1.ResourceMemory: resource.MustParse("128Mi"),
},
},
CleanupCronJob: &v1alpha1.CleanupCronJobConfig{
Expand Down
Loading