chore: upgrade @antfu/design to 0.3.0 and finish data-inspector icon TODO#110
Merged
Conversation
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Upgrades
@antfu/designfrom0.2.2to0.3.0across the catalog, adapts the surfaces to its breaking changes, and closes the outstanding data-inspector icon TODO.Version bump
pnpm-workspace.yaml:frontendcatalog@antfu/design→^0.3.0, and update theminimumReleaseAgeExcludepin to@antfu/design@0.3.0so the fresh release installs.Adapt breaking changes
ActionIconButtonno longer takes asizeprop (0.3.0 sizes offfont-size). Replacedsize="sm"withclass="text-sm"in the data-inspector (DataShapePanel,ResultViewer,SavedQueriesPanel) and inspect (App.vue) surfaces — the only direct component consumers.ActionDarkToggle,DisplayStatusPill, orFormSlider; the AppHeader dark toggle already follows the new "composeActionIconButton+ your own state" recipe.Finish data-inspector TODO
DataSourceSelect.vuerendered per-source icons through a dynamic UnoCSS class, which the build can't statically extract. Migrated both the trigger and list-item icons toDisplayIconifyRemoteIcon(vendored in 0.3.0), which resolves anycollection:iconat runtime. Declareddompurify(the component's optional peer) as an explicitfrontend-catalog devDependency of the plugin since its SPA now bundles it.Best practice
provideColorScheme, so the JS-coloredDisplayBadgesurfaces tune their contrast to the active mode instead of defaulting to light.This PR was created with the help of an agent.