fix(examples): unblock the e2e suite#113
Merged
Merged
Conversation
The next-runtime-snapshot static webServer aborted the whole Playwright run with an EACCES chmod on its copied SPA assets, and the files-inspector dev server rejected the browser's unauthenticated RPC calls. - files-inspector: opt the dev server into `auth: false`, matching the other single-user localhost demos, so the served SPA can call RPC without an OTP round-trip. - next-runtime-snapshot: normalize the built SPA's file permissions so the output is always readable/servable and downstream `createBuild` copies don't choke on dropped read bits.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pnpm test:e2ecould not complete. Playwright starts every configuredwebServer, so a single failing server aborts the whole run — and two independent problems were doing exactly that.1. Static build crashed on a permission error
The
next-runtime-snapshotstaticwebServerrunsnode bin.mjs build, which threw:next buildemits__next.*.txtRSC segment-metadata files, and thecpSyncintodist/clientcan drop their read bits, leaving unservable assets that also tripcreateBuild's recursive copy. A built SPA has to be readable to be served, so the build step now normalizes the copied tree (0755dirs /0644files) — a no-op where permissions are already correct.2. Dev server rejected unauthenticated RPC
The
files-inspectordev tests reported0files and an empty cwd because the dev server enforced auth: the browser navigates without an OTP, so RPC calls came backnot authorized. The sibling single-user demos (streaming-chat,next-runtime-snapshot) already setcli.auth: falsefor this;files-inspectorwas simply missing it.Result
npx playwright test→ 14/14 passing.pnpm lint,pnpm typecheck, andpnpm buildare clean. Changes are scoped to the two example projects; no coredevframecode was touched.This PR was created with the help of an agent.