fix: v5 release blockers — installer, binary version, repeated flags,…#51
Merged
Conversation
… upgrade, CI output
- install.ps1: fix PS 5.1 parse error (`$asset:` -> `${asset}`) that made
`irm | iex` a no-op on stock Windows; decode the octet-stream SHA256SUMS
(Byte[] under -UseBasicParsing) to text before splitting.
- build/version: stamp the version into the bun-compiled binary via
`bun --define __DCD_CLI_VERSION__` (the compiled binary can't read
package.json), so `dcd --version` no longer reports 0.0.0. npm/tsx path
still falls back to reading package.json. Adds src/global.d.ts.
- cloud: collect repeated `-e/--env`, `-m/--metadata`, `--include-tags`,
`--exclude-tags`, `--exclude-flows` from rawArgs (citty/parseArgs kept only
the last occurrence, silently dropping earlier values); echo the collected
values too.
- upgrade: query the beta channel for prerelease installs and distinguish
"no newer release on this channel" from a real network failure, replacing
the misleading "Could not reach the update manifest" error during the beta.
- progress/polling: make the realtime status indicator TTY-aware — in
non-interactive/CI output, print one line per state change instead of
flooding logs with a per-frame spinner (not suppressed by --quiet/--json-file).
- methods: downgrade primary-Backblaze-upload failure warnings to debug-only;
the Supabase fallback recovers and validateUploadResults raises the only
user-facing error (when every strategy fails).
- list/status: build console links from the env the CLI targets
(resolveFrontendUrl) instead of the API's hardcoded-prod consoleUrl.
- cloud: validate a local --app-file exists during --dry-run.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… upgrade, CI output
$asset:->${asset}) that madeirm | iexa no-op on stock Windows; decode the octet-stream SHA256SUMS (Byte[] under -UseBasicParsing) to text before splitting.bun --define __DCD_CLI_VERSION__(the compiled binary can't read package.json), sodcd --versionno longer reports 0.0.0. npm/tsx path still falls back to reading package.json. Adds src/global.d.ts.-e/--env,-m/--metadata,--include-tags,--exclude-tags,--exclude-flowsfrom rawArgs (citty/parseArgs kept only the last occurrence, silently dropping earlier values); echo the collected values too.What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test