Skip to content

fix: stop CLA locking release PRs (breaks release pipeline) #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finalerock44 merged 1 commit into from
Jun 24, 2026
Merged

fix: stop CLA locking release PRs (breaks release pipeline) #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/cla.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ jobs:
path-to-signatures: "signatures/version1/cla.json"
path-to-document: "https://github.com/devicecloud-dev/dcd-cli/blob/dev/CLA.md"
branch: "cla-signatures"
# Do NOT lock the PR on merge (the action's default is true). release-please
# comments on its release PR *after* merge; a locked conversation makes that
# comment fail and takes down the whole Release job (npm publish + binaries
# never run). Keeping this false is load-bearing for the release pipeline.
lock-pullrequest-aftermerge: false
# Internal maintainers (covered by employment/CCLA) + bots skip the prompt.
allowlist: riglar,finalerock44,dependabot[bot],renovate[bot],*[bot]
# Customise the bot's prompts if desired:
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/claude-code-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ on:

jobs:
claude-review:
# The review needs CLAUDE_CODE_OAUTH_TOKEN, which is NOT exposed to PRs that
# run without secrets — Dependabot PRs and PRs from forks. Skip them so the
# check doesn't fail with an empty token; same-repo PRs only.
if: ${{ github.event.pull_request.head.repo.full_name == github.repository && github.actor != 'dependabot[bot]' }}
# Skip PRs we shouldn't (or can't) review:
# - Dependabot / forks: no CLAUDE_CODE_OAUTH_TOKEN, so the action would fail.
# - release-please release PRs: just version bumps + changelog — nothing to
# review, and it must never block a release.
if: ${{ github.event.pull_request.head.repo.full_name == github.repository && github.actor != 'dependabot[bot]' && !startsWith(github.head_ref, 'release-please--') }}
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down
Loading